Addressed various warnings throughout the project. #493

Open
Evasion3356 wants to merge 1 commit from Evasion3356/FixWarnings into main
Evasion3356 commented 2026-03-16 01:07:08 +01:00 (Migrated from github.com)

Removed unnecessary #pragma once in a CPP file.
Fixed a collision scenario in CollisionManager, where the game had a Member and Member_0, that Member -> Member_0 collided with the static member called Member_0. Fixed typo in WindowsSectionInfo static assert.
Fixed FindPatternInRange's CurrentSkips resetting inside the for loop scope each for loop iteration.

This is the "fix" for colliding names:
image
image

This is how it looked before:

image

Branch tested in Release mode on Ready or Not UE5.3.2.0.

Removed unnecessary #pragma once in a CPP file. Fixed a collision scenario in CollisionManager, where the game had a Member and Member_0, that Member -> Member_0 collided with the static member called Member_0. Fixed typo in WindowsSectionInfo static assert. Fixed FindPatternInRange's CurrentSkips resetting inside the for loop scope each for loop iteration. This is the "fix" for colliding names: <img width="1370" height="300" alt="image" src="https://github.com/user-attachments/assets/86d4d6c2-e348-44e9-a6b1-99d4f6ad70c2" /> <img width="1391" height="362" alt="image" src="https://github.com/user-attachments/assets/90c09b64-a436-48e4-9124-c308ee1ffda4" /> This is how it looked before: <img width="1378" height="304" alt="image" src="https://github.com/user-attachments/assets/3f731b52-6ed2-4baa-896d-7614b9cb8dfa" /> Branch tested in Release mode on Ready or Not UE5.3.2.0.
Evasion3356 (Migrated from github.com) reviewed 2026-03-16 01:11:27 +01:00
Evasion3356 (Migrated from github.com) commented 2026-03-16 01:11:27 +01:00

This check seemed backwards to me. If it was intentional I can walk this change back.

This check seemed backwards to me. If it was intentional I can walk this change back.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Evasion3356/FixWarnings:Evasion3356/FixWarnings
git switch Evasion3356/FixWarnings

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff Evasion3356/FixWarnings
git switch Evasion3356/FixWarnings
git rebase main
git switch main
git merge --ff-only Evasion3356/FixWarnings
git switch Evasion3356/FixWarnings
git rebase main
git switch main
git merge --no-ff Evasion3356/FixWarnings
git switch main
git merge --squash Evasion3356/FixWarnings
git switch main
git merge --ff-only Evasion3356/FixWarnings
git switch main
git merge Evasion3356/FixWarnings
git push origin main
Sign in to join this conversation.
No description provided.